Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): bump up package dependencies #2042

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 16, 2016

Description:

This PR cleans up package.json include below changes.

  • removes es6 specific build script (es6_build_docs remains) to avoid possible confusions
  • bump up package dependencies
  • removes typings definition, use @types for devdependency type definitions
  • introduce yarn for travis build

Related issue (if exists):

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.041% when pulling bce288f on kwonoj:chore-bump into 5460e77 on ReactiveX:master.

- alias grunt=./node_modules/grunt-cli/bin/grunt

before_install:
- npm install -g npm@3 && npm install grunt@0.4.1 grunt-cli grunt-contrib-connect grunt-run
- npm install -g npm@latest && npm install -g yarn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YASSSSSSS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.041% when pulling 2aff0ef on kwonoj:chore-bump into ece1b89 on ReactiveX:master.

@jayphelps jayphelps force-pushed the chore-bump branch 2 times, most recently from 2f251d3 to 98fd2c7 Compare October 25, 2016 03:07
@coveralls
Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage remained the same at 97.041% when pulling 2aff0ef on kwonoj:chore-bump into ece1b89 on ReactiveX:master.

@jayphelps
Copy link
Member

jayphelps commented Oct 25, 2016

This was starting to fail because we merged the PR to use rollup which depends on the ES6 build output and this PR removes the scripts to build it.

I've added those scripts back, though fairly soon we probably want to think that whole thing through and make sure we're not accidentally leaking es6 into any of our npm packages.

@kwonoj can you confirm that's OK for now? Wanna get this merged since it's primary around using yarn and bumping deps.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 25, 2016

@jayphelps , yes, updated looks 👍

@jayphelps
Copy link
Member

LGTM

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants